[FIX] compatibility with compiling on AMD Instinct MI300A APU#360
Merged
glesur merged 2 commits intoidefix-code:developfrom Jan 16, 2026
Merged
[FIX] compatibility with compiling on AMD Instinct MI300A APU#360glesur merged 2 commits intoidefix-code:developfrom
glesur merged 2 commits intoidefix-code:developfrom
Conversation
glesur
approved these changes
Jan 16, 2026
Contributor
|
Kokkos::Hostspace not needed when views are declared as HostMirror |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are all the changes that I had to do for getting Idefix compiled on AMD Instinct MI300A APU system that powers MPCDF's Viper cluster (https://docs.mpcdf.mpg.de/doc/computing/viper-gpu-user-guide.html).
Many of the
create_mirrorin the code had to includeKokkos::HostSpace()however not all. In fact, the compilation fails if it is added to the ones which aren't touched in this PR (don't know the reason).