Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
c mk startcommand to request the use of a CNI network plugin. All related changes are in idearium/idearium#25.Related PRs
Verification and testing
Verification
Run these steps on
master.minikube delete.yarn linkin your repository.idearium/ideariumrepo.yarn link @idearium/cli.c mk start.c kc cmd get pods --all-namespaces.corednspods should have a status ofRunning.Testing
minikube delete.c mk start.c kc cmd get pods --all-namespaces.corednspods should remainPending(until a CNI network plugin is added to the cluster).