Add sktime detector integration#204
Add sktime detector integration#204arnavk23 wants to merge 12 commits intohyperactive-project:mainfrom
Conversation
…rOptCv, tests, example and CI
|
@fkiraly @SimonBlanke please review this pr. Thanks! |
fkiraly
left a comment
There was a problem hiding this comment.
Overall, this looks nice, but it feels like your are trying to import an evaluate function which does not exist, from sktime.
Currently there is no evaluate for detectors in sktime, so you may have to write it first there! Metrics and estimator API already exists, and imo it should be similar to forecasting. I would suggest you open an issue in sktime to add the evaluate method for detectors if it dtoes not exist, and add the routine there.
|
@arnavk23, can you describe how this is integrated with |
The mentioned PR in this pull request needs to merged first in sktime. |
|
code quality checks are failing - please use |
…g on TSDetectorOptCv
… method to TSDetectorOptCv
SktimeDetectorExperimentand a wrapper estimatorTSDetectorOptCvso Hyperactive optimizers can tune sktime detectors with the same workflow used for classifiers/forecasters.sktimedetectors integration #197