Skip to content

Conversation

@laurynasgadl
Copy link
Member

@laurynasgadl laurynasgadl commented Feb 3, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed batch deletion flow to properly respect skip trash settings, ensuring consistent behavior between single and batch item deletions.
  • Chores

    • Updated dependencies for improved stability.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Updates lodash-es dependency and refines the remove() function signature by explicitly typing the skipTrash parameter as boolean with proper string conversion for query parameters. The batch deletion component is updated to pass the skipTrash argument consistently with the single-item deletion path.

Changes

Cohort / File(s) Summary
Dependency Update
frontend/package.json
lodash-es version bumped from ^4.17.21 to ^4.17.23.
API Parameter Typing
frontend/src/api/files.ts
remove() function signature updated to explicitly type skipTrash as boolean with default value true. Implementation now converts boolean to string via toString() when building the skip_trash query parameter.
Component Alignment
frontend/src/components/prompts/Delete.vue
Batch deletion loop updated to pass this.skipTrash argument to api.remove() calls, consistent with single-item deletion behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: fixing the skip trash checkbox value to be properly sent in API requests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/skip-trash-checkbox

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurynasgadl laurynasgadl merged commit 6c0a226 into master Feb 3, 2026
4 checks passed
@laurynasgadl laurynasgadl deleted the fix/skip-trash-checkbox branch February 3, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant