Conversation
hasufell
force-pushed
the
issue-249
branch
8 times, most recently
from
8106870 to
f88c411
Compare
|
@joeyh can you test this? |
|
The amount of code inlining here is outrageous. Maybe we need to implement this function somewhere else. |
|
|
||
| -- | Get a list of 'FILEPATH's in the $PATH variable. | ||
| getSearchPath :: IO [OsPath] | ||
| #if defined(mingw32_HOST_OS) || defined(__MINGW32__) |
There was a problem hiding this comment.
At line 1507 we checked whether WINDOWS is defined, presumably in our branch it isn't so is there any need to consider mingw32 platform here?
There was a problem hiding this comment.
Ok this function will only be visible in the System.OsPath module for the current platform. It will not be present in either System.OsPath.Posix nor System.OsPath.Windows.
Still it seems in such case it may be permissible for filepath to depend on the Win32 package and reuse its environment handling functions.
There was a problem hiding this comment.
Win32 already depends on filepath, so we can't.
That's why I'm opting for haskell/directory#198
|
|
||
| #endif | ||
|
|
||
| #ifdef WINDOWS |
There was a problem hiding this comment.
Looks like sometimes it's checked as #ifdef WINDOWS and other times the check looks like #if defined(WINDOWS). I suggest to unify everything to #if defined(WINDOWS) style.
2 participants
Fixes #249