feat(asciidoctor): handle metadata#191
Open
nicorikken wants to merge 1 commit intohashobject:masterfrom
Open
Conversation
Adds metadata handling to the asciidoctor task. The asciidoctor task will now: 1. read asciidoctor attributes and add them as metadata 2. expose metadata to the asciidoctor process as attributes Both processes are executed independently from each other.
Contributor
Author
|
As promised (#100), a new Asciidoctor pull request, for handling metadata. Some notes for review:
|
Contributor
Author
|
As mentioned I'm also working on getting asciidoctor-diagram to function. I'm aiming for the inline svg solution (asciidoctor/asciidoctor#1301) as a start, not having to deal with the Boot file handing. Somehow the JRuby container cannot access the binaries on my system for the actual image generation, so that'll take some more time. Similarly perhaps syntax highlighting will become a feature. |
Closed
podviaznikov
approved these changes
Nov 14, 2017
allentiak
suggested changes
Feb 28, 2019
Contributor
allentiak
left a comment
There was a problem hiding this comment.
Hi, @nicorikken
Thanks for your hard work! Maybe this PR has never been merged because it lacks tests?
You may find useful links in #228.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds metadata handling to the asciidoctor task. The asciidoctor task will now:
Both processes are executed independently from each other.