Conversation
a672d6a to
b55f4c0
Compare
b55f4c0 to
2440e6d
Compare
Contributor
Author
Member
|
Thank you for your contribution @bassemawhoob ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This pull request adds support ActiveRecord 8.1 and improves compatibility by introducing a
NullPoolimplementation for connection pooling. It also reorganizes some internal requires for better code structure.Detail
Tableless::NullPoolclass that inherits fromActiveRecord::ConnectionAdapters::NullPooland implements thewith_pool_transaction_isolation_levelmethod for compatibility with recent ActiveRecord versions.Tableless::DummyAdapterto initialize and use the newNullPoolfor connection pooling.Fixes #6