Enable CanFD support in "serial" interface#1566
Enable CanFD support in "serial" interface#1566jacky309 wants to merge 1 commit intohardbyte:mainfrom
Conversation
jacky309
commented
Apr 13, 2023
- Remove (DLC <= 8) limitation
* Remove (DLC <= 8) limitation
|
Any feedback regarding this pull-request ? |
|
Hey @jacky309, your PR does not take into consideration the fact that a regular CAN frame shouldn't have a payload larger than 8 Byte. If you want to send CAN-FD frames over the interface, I recommend adding proper CAN-FD support to the interface.
|
|
Do you mean that the serial frame format described at https://python-can.readthedocs.io/en/master/interfaces/serial.html should be changed to introduce a new field to identify if a frame is CanFD or not ? This would be a breaking change which is likely to cause some trouble with existing software, right ? IMO, this is not acceptable. |