Fix urllib3 2.6.0+ compatibility in REST client#404
Draft
Conversation
Replace deprecated getheaders() and getheader() methods with the headers property API that works across urllib3 1.26.x and 2.x. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getheaders()andgetheader()methods with theheadersproperty API in the REST clientWhy
urllib3 2.6.0 removed the deprecated
HTTPResponse.getheader()andHTTPResponse.getheaders()methods. Since ourpyproject.tomlspecifiesurllib3 = "^2.5.0", users who install with urllib3 2.6.0+ encounter:Implementation Details
Changed
generated/groundlight_openapi_client/rest.py:The new API using
.headersand.headers.get()is backwards-compatible with both urllib3 1.26.x and 2.x.Note
Since
rest.pyis auto-generated by OpenAPI Generator, consider applying a post-generation patch or updating to a newer generator version that produces urllib3 2.6+ compatible code.🤖 Generated with Claude Code