Interfaced MailGun to allow to be easily replaced#78
Open
olivmaurel wants to merge 1 commit intographjs:masterfrom
Open
Interfaced MailGun to allow to be easily replaced#78olivmaurel wants to merge 1 commit intographjs:masterfrom
olivmaurel wants to merge 1 commit intographjs:masterfrom
Conversation
olivmaurel
commented
Jan 17, 2020
- Controllers can use the SmtpAwareTrait to inherit the smtpSendMessage() function
- Wrapped MailGunMailer into a simple class SmtpMailerMailGun interfaced to SmtpMailer
- Bumped MailGun version to 3.0
Bumped MailGun version to 3.0
Open
Contributor
|
Thank you Olivier! But in this current version, Mailgun is not really SMTP it is using REST APIs, so it should be renamed as such. You did well by creating a trait and abstracting it away from the rest of the stack, but as of now, it is too abstract it can be used for SMTP or anything (SendGrid APIs, Mailgun APIs) I think this structure is good, as long as the names reflect this attribute properly. We'd also need a second adapter with plain PHP SMTP (without relying on 3rd party requirements.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.