Fix buffer usage validity in abort_over_invalid_error test#4586
Merged
kainino0x merged 1 commit intogpuweb:mainfrom Feb 6, 2026
Merged
Fix buffer usage validity in abort_over_invalid_error test#4586kainino0x merged 1 commit intogpuweb:mainfrom
abort_over_invalid_error test#4586kainino0x merged 1 commit intogpuweb:mainfrom
Conversation
A usage of 0 is not allowed by the spec, setting it to `GPUBufferUsage.STORAGE` should get this test working properly.
kainino0x
approved these changes
Feb 6, 2026
Collaborator
kainino0x
left a comment
There was a problem hiding this comment.
oops, I thought it was intentional that this made an invalid buffer (I didn't think about the fact that it would generate a validation error causing the test to fail). That just as well would have made the mapAsync calls invalid, but this makes more sense :)
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #4575.
A usage of 0 is not allowed by the spec, setting it to
GPUBufferUsage.STORAGEshould get this test working properly.Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.