Skip to content

Fix buffer usage validity in abort_over_invalid_error test#4586

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
teoxoy:fix-usage
Feb 6, 2026
Merged

Fix buffer usage validity in abort_over_invalid_error test#4586
kainino0x merged 1 commit intogpuweb:mainfrom
teoxoy:fix-usage

Conversation

@teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 5, 2026

Fixes a regression introduced by #4575.

A usage of 0 is not allowed by the spec, setting it to GPUBufferUsage.STORAGE should get this test working properly.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

A usage of 0 is not allowed by the spec, setting it to `GPUBufferUsage.STORAGE` should get this test working properly.
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Results for build job (at 63742bb):

 Test case/subcase counts did not change.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought it was intentional that this made an invalid buffer (I didn't think about the fact that it would generate a validation error causing the test to fail). That just as well would have made the mapAsync calls invalid, but this makes more sense :)

LGTM

@kainino0x kainino0x merged commit eb9091d into gpuweb:main Feb 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants