Skip to content

[NFC] Cleanup video test#4585

Merged
alan-baker merged 1 commit intogpuweb:mainfrom
alan-baker:cleanup-video-test
Feb 4, 2026
Merged

[NFC] Cleanup video test#4585
alan-baker merged 1 commit intogpuweb:mainfrom
alan-baker:cleanup-video-test

Conversation

@alan-baker
Copy link
Contributor

  • Inline visibleRect width and height access
  • Assert visibleRect is non-null

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from kainino0x February 4, 2026 22:30
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Results for build job (at ed13a00):

 Test case/subcase counts did not change.

* Inline visibleRect width and height access
* Assert visibleRect is non-null
@alan-baker alan-baker enabled auto-merge (squash) February 4, 2026 22:53
@alan-baker alan-baker merged commit f1db17e into gpuweb:main Feb 4, 2026
1 check passed
@alan-baker alan-baker deleted the cleanup-video-test branch February 5, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants