Skip to content

Add more swizzle assignment tests#4583

Open
sudonatalie wants to merge 1 commit intogpuweb:mainfrom
sudonatalie:other-vars
Open

Add more swizzle assignment tests#4583
sudonatalie wants to merge 1 commit intogpuweb:mainfrom
sudonatalie:other-vars

Conversation

@sudonatalie
Copy link
Contributor

Add tests for swizzle assignment on vectors with address space private, workgroup and storage, including via a pointer.

These currently fail in dawn, but do pass with my local WIP implementation of swizzle assignment.

Issue: #4579


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Results for build job (at b92fecd):

-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 1 cases, 1 subcases (~1/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 2 cases, 2 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 285981 cases, 2344958 subcases
+TOTAL: 285982 cases, 2344959 subcases

.desc('Tests the value of a vector after swizzle assignment with other address spaces.')
.unimplemented();
.desc('Tests the value of a vector after swizzle assignment on other address spaces.')
.params(u => u.combine('address_space', ['private', 'workgroup']))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to combine these and the pointer tests into swizzle_assignment_local_var (and rename to vars).

I notice storage is only covered in the pointer version below. Just feels like there's very little coverage with this split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants