Open
Conversation
|
Results for build job (at b92fecd): -webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 1 cases, 1 subcases (~1/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 2 cases, 2 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 285981 cases, 2344958 subcases
+TOTAL: 285982 cases, 2344959 subcases |
38ac7b8 to
b92fecd
Compare
alan-baker
reviewed
Feb 4, 2026
| .desc('Tests the value of a vector after swizzle assignment with other address spaces.') | ||
| .unimplemented(); | ||
| .desc('Tests the value of a vector after swizzle assignment on other address spaces.') | ||
| .params(u => u.combine('address_space', ['private', 'workgroup'])) |
Contributor
There was a problem hiding this comment.
Would it make sense to combine these and the pointer tests into swizzle_assignment_local_var (and rename to vars).
I notice storage is only covered in the pointer version below. Just feels like there's very little coverage with this split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for swizzle assignment on vectors with address space private, workgroup and storage, including via a pointer.
These currently fail in dawn, but do pass with my local WIP implementation of swizzle assignment.
Issue: #4579
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.