fix: handle partial initialization in BaseApiClient GC cleanup #2022
+54
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that occurs during garbage collection if BaseApiClient fails to initialize (e.g., due to conflicting arguments). Because init can raise an exception before attributes like _http_options are set, the subsequent cleanup via del and aclose() previously failed with an AttributeError.
Added guards in close() and aclose() to ensure the client checks for the existence of these attributes before attempting to close them, allowing partially initialized objects to be garbage collected gracefully.
Fixes #2012
^ A more cleaner long-term solution would be to initialize all attributes at the very start of init. This ensures the object state is always deterministic, allowing close() and aclose() to use simple if checks instead of try-except blocks. This would require a bigger refactor. Tracked in #2023