This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix RSA keyfile open mode (rb) for python3 (#141)#142
Open
joeleong wants to merge 1 commit intogoogle:masterfrom
Open
Fix RSA keyfile open mode (rb) for python3 (#141)#142joeleong wants to merge 1 commit intogoogle:masterfrom
joeleong wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Experiencing the same issue, I validated the fix on my side with Python RSA 4.0 and Python 3.6: I followed the steps to reproduce as mentioned in #141 :
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
|
What needs to be done to get this merged? The bug in master that this PR fixes seems to make the project useless under python 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #141
I only really tested it with the
m2cryptosigner, but I assumed it would be the same forsign_pythonrsa.py