Monkey-patch os.path to support gs:// URIs#273
Open
janEbert wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
This monkey-patches the private `os.path._get_sep` function used by `os.path.join` to handle paths that start with "gs://". If a path starts with "gs://", we ignore the OS separator and return "/" as the separator to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This monkey-patches the private
os.path._get_sepfunction used byos.path.jointo handle paths that start with "gs://". If a path starts with "gs://", we ignore the OS separator and return "/" as the separator to use.Background info
For example in the
pretrained_optimizers.pyfile,os.path.joinis used to concat strings for thegs://URIs (one example).This will cause issues on Windows machines because there, URIs are concatenated with "".
Since I understand monkey-patching is always quite fickle, I can also replace all
os.path.joinusages with a new method that uses'/'.join(paths)for "gs://" paths instead.