Conversation
S-YOU
commented
Jan 21, 2017
- Still finding way to monkey patch properly.
- Temporarily put the file in pypy, please do not merge.
|
This is cool. I can think of a couple different options for integrating this off the top of my head:
The nice thing about 2. is that we could do something similar for the The downside is that the code generator gets more complicated and it needs to hardcode a small set of imports that it will pull from sys.modules and not import the associated Go package. |
|
I guess with |
|
I was thinking the code would run before any other Python code, so it should work for third_party modules. But 1. does seem a lot more hacky 2. There are a couple parts of 2. that would need to be implemented: a. Special casing some modules in the compiler so that they're pulled directly from sys.modules but no corresponding Go package is imported I'm still not convinced this is the best approach (there may be others we haven't thought of) but it does seem doable. |