Refactor: Move io to gemma/io and fix build paths#827
Closed
olaotesile wants to merge 7 commits intogoogle:devfrom
Closed
Refactor: Move io to gemma/io and fix build paths#827olaotesile wants to merge 7 commits intogoogle:devfrom
olaotesile wants to merge 7 commits intogoogle:devfrom
Conversation
Member
|
Apology accepted. |
|
baba wan be core contributor by force 😂😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really sorry about the previous attempt and the noise i attracted. I didn't verify the build properly before pushing. I already did a full refactor to get it right.
I've moved the io directory into gemma/io as requested. To make sure this is actually solid, I’ve also updated the paths across both Bazel and CMake and renamed the binary to gemma_main to avoid the ArtifactPrefixConflictException
I’ve verified this builds 100% on Ubuntu, macOS, and Windows on my own fork to ensure I’m not breaking anything for others this time.
You can see the passing CI runs here: https://github.com/olaotesile/gemma.cpp/actions/runs/20975584510
Excited to learn more!