Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wuyisheng
commented
Jul 31, 2025
Author
wuyisheng
left a comment
There was a problem hiding this comment.
checked in my pixel's phone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the documentation, for NDK versions prior to r22, you should add common-page-size 16384.
Compile-r22-lower
https://developer.android.com/guide/practices/page-sizes#compile-r22-lower
Ndk version of conscrypt-android:2.5.3 is r21d.
$ aarch64-linux-android-readelf -x 16 libconscrypt_jni_2.5.3.so Hex dump of section '.note.android.ident': 0x001e876c 08000000 84000000 01000000 416e6472 ............Andr 0x001e877c 6f696400 15000000 72323164 00000000 oid.....r21d.... 0x001e878c 00000000 00000000 00000000 00000000 ................ 0x001e879c 00000000 00000000 00000000 00000000 ................ 0x001e87ac 00000000 00000000 00000000 00000000 ................ 0x001e87bc 00000000 00000000 36353238 31343700 ........6528147. 0x001e87cc 00000000 00000000 00000000 00000000 ................ 0x001e87dc 00000000 00000000 00000000 00000000 ................ 0x001e87ec 00000000 00000000 00000000 00000000 ................ 0x001e87fc 00000000 00000000 ........Missing this configuration will cause a crash.