This repository was archived by the owner on Mar 22, 2024. It is now read-only.
Conversation
Contributor
JoeyJiao
commented
Dec 26, 2019
JoeyJiao
commented
- Android enables fortify while I don't want AFL to find these issues, so add option to disable during compile
- Android devices nowadays normally has cpu#0 as little cores while cpu#Max as big cores. so start afl on big cores by default.
In most Android devices, cpu#0 is small core while cpu#Max is big core
Contributor
Author
rebase issue, updated with only new changes. |
Contributor
Author
|
can you review the updated? @Dor1s |
Dor1s
reviewed
Jan 28, 2020
Dor1s
reviewed
Aug 5, 2020
Contributor
Dor1s
left a comment
Dor1s
left a comment
There was a problem hiding this comment.
Sorry, this version still has a lot of duplication. As I understand, the only Android-specific detail is the for-loop statement. In such case only that part should be under #ifdef, while the actual loop body can remain unconditional.
| } | ||
| } | ||
| #else | ||
| for (i = cpu_core_count - cpu_start - 1; i > -1; i--) { |
Contributor
There was a problem hiding this comment.
i is unsigned, it cannot have a negative value and thus will always be > -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.