Merged
Conversation
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
tychtjan
changed the title
hkad98
reviewed
Feb 3, 2026
packages/gooddata-dbt/pyproject.toml
Outdated
| test = [ | ||
| "pytest~=8.3.4", | ||
| "pytest-cov~=6.0.0", | ||
| "pytest-json-report", |
Contributor
There was a problem hiding this comment.
The package seems to be non-maintained anymore. The last release was done in 2022. Do we still wanna use it? If yes, lock the version to the last available release.
Author
There was a problem hiding this comment.
Even though it is not maintained it works for us and it will do the trick for now, still better than parsing it with other methods.
Overall i think there is technical debt with the test themselves and maybe in the future there should be some debate if there is better way to test it.
I will lock the version though, you are right.
tychtjan
force-pushed
the
feat/json-reports-tests
branch
from
b31c646 to
b667f35
Compare
Author
|
Pinned pytest-json-report to ==1.5.0 (last known release from 2022) due to maintenance concerns, and refreshed uv.lock. |
hkad98
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pytest JSON test reporting across packages
Report will be used for future parsing for autonomous agent, to see which tests are failing and getting context from the log.
jira: DX-334
risk: low