This repository was archived by the owner on Jan 15, 2022. It is now read-only.
use parameter props instead of property props#247
Open
RusAlex wants to merge 2 commits intoglittershark:masterfrom
Open
use parameter props instead of property props#247RusAlex wants to merge 2 commits intoglittershark:masterfrom
RusAlex wants to merge 2 commits intoglittershark:masterfrom
Conversation
Owner
|
As I said on the closed PR, I'd like to see some tests covering what was broken. Also you can just amend the commit and force-push 😄 |
Author
|
Is it going to be merged ? I still use patched version for my project. Want to have original source for the package. |
Owner
|
What's going on with the changes to build/tests/reactable_test.jsx? |
Author
|
Ah yep sorry. I will check asap and let you know.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.