KV.watch a key for change#5
Open
chrisDeFouRire wants to merge 3 commits intogjohnson:masterfrom
chrisDeFouRire:master
Open
KV.watch a key for change#5chrisDeFouRire wants to merge 3 commits intogjohnson:masterfrom chrisDeFouRire:master
chrisDeFouRire wants to merge 3 commits intogjohnson:masterfrom
chrisDeFouRire:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know it's just a convenience, but I thought you might like it.
kv.watch allow you to get the value of a key, and to be called back each time the key is changed, until you decide to stop it. It uses HTTP long polling, and retries every second in case of Consul error (handler will receive errors too).
I've added unit tests, but the last one takes 11s to run (waiting for an http timeout).