Improve description of backoff sequence in db.loose#119
Merged
Byron merged 1 commit intogitpython-developers:masterfrom Jan 27, 2025
Merged
Improve description of backoff sequence in db.loose#119Byron merged 1 commit intogitpython-developers:masterfrom
db.loose#119Byron merged 1 commit intogitpython-developers:masterfrom
Conversation
The sequence of backoff wait times used in `gitdb.db.loose` is quadratic rather than exponential, as discussed in: gitpython-developers#115 (comment) This corrects the variable name by making it more general, and the comment by having it explicitly describe the backoff as quadratic. This is conceptually related to GitoxideLabs/gitoxide#1815, but this is a non-breaking change, as no interfaces are affected: only a local variable and comment.
Byron
approved these changes
Jan 27, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot!
It looks like this mistake has been following me since my youth 😄.
Member
Author
|
No problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence of backoff wait times used in
gitdb.db.looseis quadratic rather than exponential, as discussed in #115 (comment).This corrects the variable name by making it more general, and the comment by having it explicitly describe the backoff as quadratic.
This is conceptually related to GitoxideLabs/gitoxide#1815, but this is a non-breaking change, as no interfaces are affected: only a local variable and comment.