fix updating submodules with relative urls#2051
Merged
Byron merged 1 commit intogitpython-developers:mainfrom Jun 11, 2025
Merged
fix updating submodules with relative urls#2051Byron merged 1 commit intogitpython-developers:mainfrom
Byron merged 1 commit intogitpython-developers:mainfrom
Conversation
This fixes running repo.update_submodules(init=True) on repositories that are using relative for the modules. Fixes gitpython-developers#730
david0
force-pushed
the
fix-issue-730-relative-submodule
branch
from
76f3bf3 to
1d80891
Compare
Byron
approved these changes
Jun 11, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot!
Even though I cannot truly say I know this is correct, there is a test that would probably fail with an exception without the fix so it's better than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes running repo.update_submodules(init=True) on repositories that are using relative for the modules.
It tries to emulate the git behavior: https://github.com/git/git/blob/master/builtin/submodule--helper.c#L503
Fixes #730