JSON-safe comma splitting for override options (--fact-override, --enc-override)#340
Open
isaiahfrantz wants to merge 2 commits intogithub:masterfrom
Open
JSON-safe comma splitting for override options (--fact-override, --enc-override)#340isaiahfrantz wants to merge 2 commits intogithub:masterfrom
isaiahfrantz wants to merge 2 commits intogithub:masterfrom
Conversation
added 2 commits
January 27, 2026 12:31
Replace option_globally_or_per_branch with explicit parser.on handlers to avoid automatic Array parsing that splits on commas, allowing JSON fact overrides containing commas to remain intact.
Add split_override_list method to parse comma-separated override values while preserving commas inside JSON arrays and objects. Update fact-override and enc-override options to accept comma-separated lists using explicit parser.on handlers. Add tests for comma-separated parsing and JSON value preservation. Update documentation to describe comma-separated list support.
Author
|
@ngrundy can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores support for comma-separated override lists while preserving JSON values that contain commas (e.g., JSON arrays). It also refactors the parsing logic into a shared helper to avoid duplication across override option classes.
What changed
Override parsing
--fact-override,--to-fact-override,--from-fact-overridenow accept:STRING1[,STRING2[,...]][]/{}), so values like:json_list=(json)["a","b"]remain intact.
DRY refactor
Tests
Docs
Why
Previously, comma-separated lists were disabled to avoid breaking JSON values (since JSON arrays/objects contain commas). This PR enables both:
foo=bar,baz=buzzjson_list=(json)["a","b","c"]Testing
bundle exec rspec \ spec/octocatalog-diff/tests/cli/options/fact_override_spec.rb \ spec/octocatalog-diff/tests/cli/options/enc_override_spec.rb