fix(dart-symbol-map): Resolve org from token via config#3113
Open
szokeasaurusrex wants to merge 4 commits intomasterfrom
Open
fix(dart-symbol-map): Resolve org from token via config#3113szokeasaurusrex wants to merge 4 commits intomasterfrom
szokeasaurusrex wants to merge 4 commits intomasterfrom
Conversation
szokeasaurusrex
commented
Jan 30, 2026
Comment on lines
-1
to
-9
| # Adding new commands | ||
| For new commands, it is recommended to use clap's [Derive API](https://docs.rs/clap/latest/clap/_derive/index.html). | ||
| In contrast to the [Builder API](https://docs.rs/clap/latest/clap/_tutorial/index.html), the Derive API makes it: | ||
| - Easier to read, write, and modify commands and arguments. | ||
| - Easier to keep argument declaration and reading in sync. | ||
| - Easier to reuse shared arguments. | ||
|
|
||
| An existing example of how to use the Derive API is the `send-metric` command. | ||
|
|
Member
Author
There was a problem hiding this comment.
I still would like to eventually migrate to the derive API, but mixing the derive API with the builder API seems to be problematic; it is also the root cause of this bug.
So, if we migrate we should do it all at once
szokeasaurusrex
force-pushed
the
cursor/dart-symbol-map-org-resolution-builder
branch
from
9ec474a to
55faf04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dart-symbol-mapto the clap builder pattern to align with most commands.Confighelpers so org auth tokens take precedence.Issues
dart-symbol-map uploaddoes not resolve org from token #3063Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.