This repository was archived by the owner on Oct 23, 2023. It is now read-only.
No longer provide form data for Flask. Fixes #457#977
Open
No longer provide form data for Flask. Fixes #457#977
Conversation
dcramer
approved these changes
Mar 2, 2017
Member
dcramer
left a comment
dcramer
left a comment
There was a problem hiding this comment.
im assuming it isnt possible to say "is this streaming" to decide if we could opportunistically capture it?
Contributor
Author
|
@dcramer there are some ways to do it but it is not a stable API in Flask. Ideally we could access the cache value in case it has been pulled in before. |
Contributor
Author
|
Makes we wonder what we do in Django. That should in theory have the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this feature does not make much sense, particularly because we badly
trim down the form data on the server anyways for security and size reasons.