This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Only print to stdout if stdout is connected to a tty(-like) device#941
Open
frietsch-ot wants to merge 2 commits intogetsentry:masterfrom
Open
Only print to stdout if stdout is connected to a tty(-like) device#941frietsch-ot wants to merge 2 commits intogetsentry:masterfrom
frietsch-ot wants to merge 2 commits intogetsentry:masterfrom
Conversation
raven/transport/threaded.py
Outdated
| else: | ||
| print("Press Ctrl-C to quit") | ||
|
|
||
| if sys.stdout.isatty(): |
Contributor
There was a problem hiding this comment.
Should test against stdin, not stdout.
Author
There was a problem hiding this comment.
Hm... as we are printing to stdout, I'd propose to - if you want to test for stdin - to test for both. At least, I also don't want to see those messages when redirecting a console application to a file, maybe by nohup or something.
import sys
sys.stdout.isatty()
True
on my machine.
Author
|
How do you think about that "if sys.stdin.isatty() and sys.stdout.isatty()" in my last commit? |
|
Would be great to see this merged anytime soon. |
|
Hi all, We have similar issue, but i think it would be better to print these messages to STDERR instead of STDOUT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are running the raven python client inside of a (yes, very old school, I agree) CGI web application and would like to use a threaded transport, so that normal operation can continue while raven is working.
However, in rare but not rare enough cases, the CGI process is about to terminate before raven has sent all messages, and then, some output "Sentry is attempting to send... Hit Ctrl+C to abort" appears on stdout, which - lame old CGI - is the web page sent to the client. In worst case, the output is seen as (broken) HTTP headers, leading to interesting HTTP status codes from the web server.
To avoid the stdout output, as discussed in #932, I just added an isatty() check.
So: The overall diff is very small in fact, it's just that I had to change a bit of indent.