This repository was archived by the owner on Oct 23, 2023. It is now read-only.
fix(flask): Use request.get_json instead of data#1070
Open
fix(flask): Use request.get_json instead of data#1070
Conversation
request.data returns a string when we are expecting json/dict as the event data. Fixes PY-RAVEN #1067
mitsuhiko
approved these changes
Sep 4, 2017
Contributor
mitsuhiko
left a comment
There was a problem hiding this comment.
Looks good but let's please verify that this is what the server indeed wants :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.data returns a string when we are expecting json/dict
as the event data.
PY-RAVEN Fixes #1067