Use repository owner for scope by default#71
Open
tspascoal wants to merge 1 commit intogetsentry:mainfrom
Open
Use repository owner for scope by default#71tspascoal wants to merge 1 commit intogetsentry:mainfrom
tspascoal wants to merge 1 commit intogetsentry:mainfrom
Conversation
If scope parameter wasn't passed it used empty by default. This means a token would be returned for the first installation id on the list. If the app had a single install this would work fine, otherwise the user will get a token scope to an owner that he didn't meant to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18
If scope parameter wasn't passed it used empty by default.
This means a token would be returned for the first installation id on the list.
If the app had a single install this would work fine, otherwise the user will get a token scope to an owner that (probably) didn't meant to.
With this change it now uses the current repo owner (org or account).
As a check this step can be used to list the repos to which the returned token has access to