-
Notifications
You must be signed in to change notification settings - Fork 75
test: ensure all hf tests run (cuda) #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
This PR will now allow the running of the hf tests on a well-provisioned environment. Rebased ~hour ago - appreciate any review comments, after which I can squash and rebase to clean up commit log & run a final test. |
3876742 to
938cc89
Compare
- Add @pytest.mark.ollama to tests requiring Ollama backend - Update test/README.md with comprehensive marker documentation - Update .gitignore for logs/ and pytest output files
Test Infrastructure Improvements
Type of PR
Description
Fixes test infrastructure issues preventing tests from running on systems without required backends. Tests were failing at collection time due to backend initialization at import and missing markers.
Fixes #396
Changes:
start_session()at class/module definition time (moved to fixtures)ollamaandllmmarkers to tests using default backendollamamarker to guardian safety examples (guardian.py,guardian_huggingface.py)test_kvwithxfail(strict=False)- model safety refusal despite contexttest_kvFlaky Due to Model Safety Refusal #398 for proper fix to testdocs/examples/aLora/101_example.pywithskipmarkerdocs/examples/mify/rich_document_advanced.py- CXXABI_1.3.15 not found on HPC systems with old glibctest/README.mdmps=yesfor LSF)Results: 34/34 HuggingFace tests pass on HPC with MPS enabled. Tests properly skip when backends unavailable.
Verification:
Testing