Skip to content

fix: fix vllm test skip #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akihikokuroda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix vllm test skip #394

akihikokuroda wants to merge 1 commit into from
+39 −18

Conversation

@akihikokuroda
Copy link
Member

@akihikokuroda akihikokuroda commented Jan 31, 2026 •
edited
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Jan 31, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

nrfulton
nrfulton approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@nrfulton nrfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akihikokuroda
fix vllm test skip
c89c5cc 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
planetf1
planetf1 approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good to get it merged as we iterate on improving test usability in differing configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrfulton nrfulton nrfulton approved these changes

@planetf1 planetf1 planetf1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vllm tests failed without vllm install

3 participants

@akihikokuroda @nrfulton @planetf1