Remove :static_symbol result field names#691
Open
larskanis wants to merge 1 commit intoged:masterfrom
Open
Conversation
larskanis
force-pushed
the
remove-static_symbol
branch
from
6538eb5 to
20b7b5f
Compare
They were just for performance testing, but they have the same speed as :symbol.
larskanis
force-pushed
the
remove-static_symbol
branch
from
20b7b5f to
f8c863c
Compare
Contributor
|
Yeah, this makes sense. Unless you can show there there is a major performance improvement from this it does not seem like worth the complexity in choices for the user. And it also does not seem like anyone, at least on Github, even uses it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were just for performance testing, but they have the same speed as :symbol.
Truffleruby also supports the dynamic symbols API in the meantime, so that there's no reason to keep the static symbols any longer.