Add workaround to accept GL canonical names without a commit ID#306
Open
NotTheEvilOne wants to merge 1 commit intomainfrom
Open
Add workaround to accept GL canonical names without a commit ID#306NotTheEvilOne wants to merge 1 commit intomainfrom
NotTheEvilOne wants to merge 1 commit intomainfrom
Conversation
NotTheEvilOne
force-pushed
the
fix/workaround-broken-cnames-302
branch
from
d145fdb to
c8664d2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 91.73% 91.61% -0.12%
==========================================
Files 42 42
Lines 2105 2123 +18
==========================================
+ Hits 1931 1945 +14
- Misses 174 178 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NotTheEvilOne
force-pushed
the
fix/workaround-broken-cnames-302
branch
2 times, most recently
from
2e61e56 to
aac30a6
Compare
Fixes: #302 Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
force-pushed
the
fix/workaround-broken-cnames-302
branch
from
aac30a6 to
03c1db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a workaround as we currently have a misalignment between tools handling Garden Linux canonical names.
Which issue(s) this PR fixes:
Fixes #302