Conversation
Contributor
|
@MalteJ Thank you for your contribution. |
gardener-robot
added
needs/review
gardener-robot
added
size/m
Contributor
|
@Vincinator, @nkraetzschmar, @gehoern You have pull request review open invite, please check |
Vincinator
requested changes
Jun 21, 2023
Contributor
Vincinator
left a comment
Vincinator
left a comment
There was a problem hiding this comment.
We should think about how we distribute the script required to use the builder.
Copying them from a documentation is not the best idea
Contributor
There was a problem hiding this comment.
We should not copy the files also in docs/example, this would introduce duplicates (e.g. build and docs/example/build).
Question is: How do I update the build script in gardenlinux/gardenlinux/build with latest changes from gardenlinux/builder/build?
Contributor
|
@MalteJ is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1