An adaptation of FSharp.Charting to .NET Core 3.1 on Windows 10.#145
Open
hello-sergei wants to merge 1 commit intofslaborg:masterfrom
Open
An adaptation of FSharp.Charting to .NET Core 3.1 on Windows 10.#145hello-sergei wants to merge 1 commit intofslaborg:masterfrom
hello-sergei wants to merge 1 commit intofslaborg:masterfrom
Conversation
…1 on Windows 10.
Contributor
|
Thank you for that! I am having hard times to make it work in .net core 3.1 for windows 10, hope this one helps. |
Member
|
This looks very promising.
If it's working well I think we should just make this the new v3.0 version going forward (so v2.0 is the last for .NET Framework) |
Member
|
@hello-sergei Could you rejig things so that this literally replaces the current version? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed this for rapid debugging. Thought it could be of interest to others. Don't have enough knowledge about the code base for accurately merging into master without causing regressions on other .NET variants, thus created the incubation directory.
The changes are minor, yet they were tricky to figure out, especially in the configuration files. I hope it'll save you time in case you'd like to keep the library going. Also, the FSharp.Charting example in the Expert F# 4.0 book will now work on .NET Core 3.1.
Not sure how well the configuration files will be processed by Visual Studio. A working JetBrains Rider 2019.3.1 solution can be found here: https://github.com/hello-sergei/FsharpChartingCore. Thanks for the wonderful F# ecosystem!