Add CI for submitting plugins to Marketplace on merge#548
Add CI for submitting plugins to Marketplace on merge#548niekert wants to merge 4 commits intoframer:mainfrom
Conversation
| github.event.pull_request.merged == true && | ||
| contains(github.event.pull_request.labels.*.name, 'Submit on merge') | ||
| # FIXME: Should be production | ||
| environment: development |
There was a problem hiding this comment.
note to self to fix before merging.
| ERROR_WEBHOOK_URL: ${{ secrets.ERROR_WEBHOOK_URL }} | ||
| RETOOL_URL: ${{ secrets.RETOOL_URL }} | ||
| # FIXME: Should be production | ||
| FRAMER_ENV: development |
| const SubmissionResponseSchema = v.object({ | ||
| version: v.number(), | ||
| // FIXME: THIS SHOULD BE DEPLOYED: | ||
| // SEE: https://github.com/framer/creators/pull/2487/files |
There was a problem hiding this comment.
note to self: remove the fallback
niekert
force-pushed
the
main
branch
2 times, most recently
from
2975293 to
cfb070c
Compare
|
@cursor review |
|
/gemini review |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
| github.event.pull_request.merged == true && | ||
| contains(github.event.pull_request.labels.*.name, 'Submit on merge') | ||
| # FIXME: Should be production | ||
| environment: development |
There was a problem hiding this comment.
Development environment hardcoded instead of production
High Severity
The workflow has environment: development and FRAMER_ENV: development hardcoded with FIXME comments. The PR notes explicitly state "note to self to fix before merging." If merged as-is, all plugins submitted via the "Submit on merge" flow would go to the development environment instead of production.
Additional Locations (1)
| package.json | ||
| yarn.lock | ||
| .yarnrc.yml | ||
| .yarn |
There was a problem hiding this comment.
Sparse checkout missing required .tool-versions file
High Severity
The sparse checkout configuration does not include .tool-versions, but the Setup Node.js step on line 51 requires this file via node-version-file: .tool-versions. The workflow will fail because the file won't exist after the sparse checkout completes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfb070c03c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
niekert
force-pushed
the
main
branch
8 times, most recently
from
efb8561 to
1abd9e6
Compare
- Add GitHub Actions workflows for plugin submission - Add scripts for validating PR body and submitting plugins - Add test:scripts command and related dev dependencies - Update PR template
1 participant
Description
This PR adds new Github action workflows:
Submit on Merge
Submit on mergelabel is added to a PRSubmit Plugin
pluginPathandchangeloginputCheck PR body
Pre merge Checklist
developmentandproductionenvironments in framer/plugins CI and configure secrets and env variablesdevelopmenttoproductionin CI jobs after QA#team-pluginsinstead of#testTesting
Please test in the fork to test the PR workflow: niekert/plugins.
LMK when you start QA I will give you full repo permissions.
plugins/csv-importfor the plugin path#testslack channel when completed. Test the links in the slack message.niekert/pluginsfork locally and create a new branchcsv-importplugin succesfullymainafter the merge