WIP: undocumented feature: dimension_#738
Draft
jodavies wants to merge 2 commits intoform-dev:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some small fixes and tests of the undocumented
dimension_. I've no idea how well tested this is or if it has ever been used in user scripts. If it works properly, we should add it to the manual.Needing to use
ArgToExtraSymbolto trigger the dimension check feels a bit awkward, but perhaps it is not great, performance wise, to triggerDimensionExpressiontoo often. This could alternatively be a manually-run statement?CheckDimension,2,f;or something? It would have to correctly deal with PolyRatFun...