Skip to content

fix: disable user request access popup buttons if no user is selected#779

Open
tomrndom wants to merge 1 commit intomasterfrom
fix/sponsor-user-request-btn
Open

fix: disable user request access popup buttons if no user is selected#779
tomrndom wants to merge 1 commit intomasterfrom
fix/sponsor-user-request-btn

Conversation

@tomrndom
Copy link

@tomrndom tomrndom commented Feb 4, 2026

ref: https://app.clickup.com/t/86b84fuw0

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

Bug Fixes

  • Request processing buttons in the sponsor users list are now disabled when no items are selected.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet February 4, 2026 21:00
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This change adds client-side disable state to the dismiss and admit action buttons in the ProcessRequestPopup component. Both buttons now disable when no items are selected, preventing unintended user actions.

Changes

Cohort / File(s) Summary
Button State Management
src/pages/sponsors/sponsor-users-list-per-sponsor/components/process-request-popup.js
Added conditional disable state to dismiss and admit buttons based on selection count (selected.length === 0). Admit button reformatted across multiple lines while preserving onClick handler.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • smarcet

Poem

🐰 Hop, hop, hooray! The buttons now know,
When selections are gone, they must rest and not go,
No more misclicks when nothing is there,
Smart UI guards—oh, what careful care! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling popup buttons when no users are selected, which directly matches the code modifications that add disabled state to action buttons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sponsor-user-request-btn

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant