Skip to content

feature: add open telemetry integration#3

Open
fcarreno-collab wants to merge 4 commits intomasterfrom
feature/olt_middleware
Open

feature: add open telemetry integration#3
fcarreno-collab wants to merge 4 commits intomasterfrom
feature/olt_middleware

Conversation

@fcarreno-collab
Copy link

@fcarreno-collab fcarreno-collab marked this pull request as ready for review January 16, 2026 20:01
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're defining randomString in api/tests/open_telemetry_instrumentation_tests.py but not using it:

class OpenTelemetryInstrumentationTest(APITestCase):
    def randomString(self, str_len):
...

Wrapt was downgraded in the requirements.txt. Was that intentional?
wrapt==2.0.1 -> wrapt==1.17.3

@fcarreno-collab
Copy link
Author

You're defining randomString in api/tests/open_telemetry_instrumentation_tests.py but not using it:

class OpenTelemetryInstrumentationTest(APITestCase):
    def randomString(self, str_len):

@caseylocker I removed this code you are right, its not been used, this was to generate a random string for the access_token we use to authenticate the requests on the other endpoints but here that does not happen

Wrapt was downgraded in the requirements.txt. Was that intentional? wrapt==2.0.1 -> wrapt==1.17.3

@caseylocker it was on propuse because newer versions create dependency conflicts when we try to install the open telemetry instrumentation libraries

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've confirmed that the wrapt downgrade was a requirement by the Opentelementry instrumentation packages. They explicitly require wrapt<2.0.0. No other packages require wrapt 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants