Skip to content

Conversation

@chunhtai
Copy link
Contributor

also opts in go_router

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Jan 22, 2026
@chunhtai chunhtai marked this pull request as ready for review January 27, 2026 23:32
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the CI checks for batch release file integrity by adding validation for workflow files, triggers, and branches for packages that opt into batch releases. It also opts in the go_router package to this new system. The changes are well-tested and improve the reliability of the release process. I have a few suggestions to further improve the robustness of the new checks and clean up a minor code duplication issue in the tests.

@chunhtai chunhtai added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 29, 2026
@chunhtai
Copy link
Contributor Author

reason for override, ci change that doesn't affect go_router functionality

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes, but per my comment on the docs PR I just realized we haven't fixed update-release-info yet. Since that's what we tell contributors to use, we shouldn't land this until that's been updated.

@@ -0,0 +1,3 @@
changelog: |
- Converts go_router to use batch release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the resolution of the comment thread was that this wasn't going to have a changelog entry?

There is no change in any part of the package that affects clients.

}

final String content = workflowFile.readAsStringSync();
YamlMap? yaml;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no versioning needed Override the check requiring version bumps for most changes p: go_router triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants