-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] Adds more ci checks for batch release file integrity #10859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3726697 to
a72cb6d
Compare
32a0557 to
dcd190f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the CI checks for batch release file integrity by adding validation for workflow files, triggers, and branches for packages that opt into batch releases. It also opts in the go_router package to this new system. The changes are well-tested and improve the reliability of the release process. I have a few suggestions to further improve the robustness of the new checks and clean up a minor code duplication issue in the tests.
|
reason for override, ci change that doesn't affect go_router functionality |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor changes, but per my comment on the docs PR I just realized we haven't fixed update-release-info yet. Since that's what we tell contributors to use, we shouldn't land this until that's been updated.
| @@ -0,0 +1,3 @@ | |||
| changelog: | | |||
| - Converts go_router to use batch release. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the resolution of the comment thread was that this wasn't going to have a changelog entry?
There is no change in any part of the package that affects clients.
| } | ||
|
|
||
| final String content = workflowFile.readAsStringSync(); | ||
| YamlMap? yaml; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: final
also opts in go_router
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3