Prepare filter for moving to shared#9487
Open
srawlins wants to merge 2 commits intoflutter:masterfrom
Open
Conversation
Work towards flutter#7793
Contributor
|
Greetings from stale PR triage! 👋 |
bkonyi
approved these changes
Jan 14, 2026
Contributor
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
Not sure how this slipped past me, but LGTM if we still want to land it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #7793
In this CL, we are just preparing this code to be moved into shared code, but it is not shared here.
I tried to make as much private as possible. That is, when there are methods or fields that are currently only used privately, I make it private, with the idea it is not an API appropriate/necessary for public consumption. In a few cases, a method or field is used privately and in tests. In those cases, I made APIs
@visibleForTesting.I also adjusted comments a bit, as these will be published documentation.