add discard_logs_on_reconnect_error in asyncsender#176
add discard_logs_on_reconnect_error in asyncsender#176enjoy-binbin wants to merge 1 commit intofluent:masterfrom
Conversation
5a23fd5 to
c7b7a70
Compare
|
I'll review it at depth when I have time, but I'm inclined not to accept this change. Unless I'm missing something the error should lead to a reconnect and resending of the logs. Clearing the queue will cause the loss of perfectly good logs due to a simple reconnect issue, which would not be acceptable. |
|
Yep Not problem. I understand it is risky Or maybe we should just print some logs to help the user for debug |
|
We can consider a tunable setting which would "discard logs on reconnect" and defaults to I tend to make decisions against arbitrary loss of data. |
|
Right. I can give a try. Thanks @arcivanov |
c7b7a70 to
44ba7a6
Compare
Signed-off-by: enjoy-binbin <binloveplay1314@qq.com>
44ba7a6 to
6995dbb
Compare
|
@arcivanov |
issue: #175
When using asyncsender, there is a queue holds the logs to be send:
This is my solution, it doesn’t look particularly good. so feel free to close this if un-needed