Open
Conversation
mcipperly
force-pushed
the
ipv6test
branch
6 times, most recently
from
c5cfd18 to
3e2c2e6
Compare
Author
|
Apologies for the spam, my git is rusty and I haven't built on another PR previously! Travis doesn't seem to support IPv6 (more info here and here ) so I did add a condition to skip in that case. Unfortunately this causes the IPv6 code to still not be covered through CI testing infrastructure - open to thoughts on how to address if this isn't workable. |
|
@mcipperly could you rebase tihis pull request? |
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
kenhys
reviewed
Apr 23, 2021
| else: | ||
| sock = socket.socket(socket.AF_INET6, | ||
| socket.SOCK_STREAM) | ||
| sock.settimeout(self.timeout) |
There was a problem hiding this comment.
Does it need to call _is_ipv4_host() in every _make_packet?
It may be able to reuse checked status.
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Author
|
Updated to address the above re: not wanting to determine v4/v6 capability each time. Now:
Also added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a test for PR #138 which adds IPv6 support ( #137 )