convert argument fmt into dict if argument is a string#169
Open
harish2704 wants to merge 1 commit intofluent:masterfrom
Open
convert argument fmt into dict if argument is a string#169harish2704 wants to merge 1 commit intofluent:masterfrom
fmt into dict if argument is a string#169harish2704 wants to merge 1 commit intofluent:masterfrom
Conversation
FluentRecordFormatter is expecting fmt to be either a callable or a dict. But there is no strict type checking is done to check whether the variable is dict or not. There are many situations in which `fmt` can have a string value. For eg: if logger is loading configuration from a config file using [ConfigParser](https://docs.python.org/2/library/configparser.html) , then there is no way to specify a dict inside the config file. This change is backward compatible from Python2.7 to Python3.8 since `ast.literal_eval` will work in same way since python 2.6+ Signed-off-by: Harish Karumuthil <harish2704@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluentRecordFormatter is expecting fmt to be either a callable or a dict. But there is no strict type checking is done to check whether the variable is dict or not.
There are many situations in which
fmtcan have a string value.For eg: if logger is loading configuration from a config file using ConfigParser , then there is no way to specify a dict inside the config file.
This change is backward compatible from Python2.7 to Python3.8 since
ast.literal_evalwill work in same way since python 2.6+