fix a signal creation bug#3973
Draft
robert-gurol-ebcont wants to merge 1 commit intoflowable:mainfrom
Draft
Conversation
fix a bug where for the second process you start, signal processing would happen differently (e.g. scope would always be null)
robert-gurol-ebcont
force-pushed
the
fix/keep-signal-ref-intact
branch
from
68d447e to
92f1aab
Compare
Contributor
|
Hi, I think a good place to look for is here https://github.com/flowable/flowable-engine/tree/main/modules/flowable-engine/src/test/java/org/flowable/engine/test/bpmn/event/signal. You can add it to the existing SignalEventTest unit test for example. Let me know if you need more info. |
Author
|
Thank you! I'll have a look ❤️ PS: The existing tests still run with my change applied 🙈 |
Contributor
|
That's good that this test still runs. But it would be great if there could be a test added that's failing without your fix if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #3920
@tijsrademakers I specifically asked for pointers in that pull request about where to add a unit test for this - I don't see through the big overall structure of the repository. I want to add unit tests, but I need your help to tell me what I can build on.
EDIT: The code was recently changed here, without any changes to unit tests - I really would have liked to know where to look for those 024ba64