Skip to content

fix(domains): Remove redundant legacy domain migration #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfebe merged 1 commit into from
Feb 3, 2026
Merged

fix(domains): Remove redundant legacy domain migration #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/views/DeploymentDetailView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,23 +1798,8 @@ const fetchProxyStatus = async () => {
const handleAddDomain = async (newDomain: any) => {
if (!deployment.value?.metadata) return;

const currentDomain = deployment.value.metadata.networking?.domain;
const currentPort = deployment.value.metadata.networking?.container_port || 80;
const currentSSL = deployment.value.metadata.ssl || { enabled: false, auto_cert: false };

addingDomain.value = true;
try {
// First, convert existing legacy domain to a domain config
if (currentDomain) {
await deploymentsApi.addDomain(route.params.name as string, {
service: deployment.value.metadata.name || (route.params.name as string),
container_port: currentPort,
domain: currentDomain,
ssl: currentSSL,
});
}

// Then add the new domain
await deploymentsApi.addDomain(route.params.name as string, {
service: newDomain.service || deployment.value.metadata.name || (route.params.name as string),
container_port: newDomain.container_port || 80,
Expand Down