fix(ssl): Resolve missing SSL blocks in vhosts #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review SummaryThis pull request introduces several important improvements to domain and SSL certificate management, alongside comprehensive test coverage. Key changes involve refining the logic for adding domains to deployments, especially concerning the defaulting of container ports, and correcting the behavior of SSL certificate requests to properly consider auto-certification independently of the SSL enablement status. The added test cases significantly boost confidence in the robustness and correctness of these features. 🚀 Key Improvements
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
nfebe
changed the title
nfebe
force-pushed
the
fix/ssl-config-missing-on-new-domain
branch
from
2a9faff to
96c23f3
Compare
Certificate requests were skipped because the orchestrator pre-disabled SSL.Enabled for domains without existing certs, and RequestCertificatesForDomains required both Enabled and AutoCert. Now only AutoCert drives certificate requests. Also default new domain container_port from legacy networking config when omitted, preventing wrong port in nginx upstream. Closes #75 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/ssl-config-missing-on-new-domain
branch
from
96c23f3 to
4f3478c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate requests were skipped because the orchestrator pre-disabled SSL.Enabled for domains without existing certs, and RequestCertificatesForDomains required both Enabled and AutoCert. Now only AutoCert drives certificate requests.
Also default new domain container_port from legacy networking config when omitted, preventing wrong port in nginx upstream.
Closes #75