Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Feb 4, 2026

Long domain names (e.g., auto-generated subdomains) can exceed the default bucket size of 64, causing nginx config test to fail with:

[emerg] could not build server_names_hash, you should increase
server_names_hash_bucket_size: 64

Increasing to 128 accommodates longer domain names.

@sourceant
Copy link

sourceant bot commented Feb 4, 2026

Code Review Summary

✨ This pull request primarily standardizes the server_names_hash_bucket_size directive across several Nginx configuration files, which is a good practice for preventing issues with server name processing. However, a potentially impactful change in templates/infra/nginx/nginx.conf needs attention regarding network performance.

🚀 Key Improvements

  • Standardization of server_names_hash_bucket_size 128; across multiple Nginx configurations (templates/infra/nginx/nginx.conf, test/e2e/nginx/lua/nginx.conf, test/e2e/nginx/nginx.conf, test/e2e/nginx/security/nginx.conf). This helps prevent hash table overflow issues with a large number of server names.

💡 Minor Suggestions

  • Consider adding tcp_nodelay on; back into templates/infra/nginx/nginx.conf for optimal network performance, especially for interactive content or APIs.

🚨 Critical Issues

  • The removal of tcp_nodelay on; in templates/infra/nginx/nginx.conf may subtly degrade network performance by reintroducing Nagle's algorithm, potentially increasing latency for small data packets. It's recommended to reinstate this directive.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

Long domain names (e.g., auto-generated subdomains) can exceed the
default bucket size of 64, causing nginx config test to fail with:

  [emerg] could not build server_names_hash, you should increase
  server_names_hash_bucket_size: 64

Increasing to 128 accommodates longer domain names.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix/nginx-server-names-hash branch from 176ed6a to 91152a7 Compare February 4, 2026 10:00
@nfebe nfebe changed the title fix(nginx): increase server_names_hash_bucket_size to 128 fix(nginx): Increase server_names_hash_bucket_size to 128 Feb 4, 2026
Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@nfebe nfebe merged commit ecc6bda into main Feb 4, 2026
5 checks passed
@nfebe nfebe deleted the fix/nginx-server-names-hash branch February 4, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant